[transmission] Transmission 1.76 + DHT download and discussion (OLD THREAD)

[hdfan]

(06-23-2009 01:49 AM)bloodflower Wrote:  are you sure that we should set the preallocation=2?
i see the ticket discussion in the official site, does it mean we should set the preallocation=3?

" Replying to charles:

Why do we need a new preallocation type? What if we were to just add another "if( !success )" test that contained the write-in-a-loop code?

I've done it as a separate option for two reasons: 1) I wanted everything to work as before with old settings, to be sure that nobody will be harmed by this patch; 2) More importantly, I'm not completely sure that fallocate and/or posix_fallocate are absent on our platforms or that they return non-zero (fail). I'm even quite sure that (one of them or both) return 0 because files ARE preallocated (however, in a sparse mode, prone to fragmentation). However, I may be wrong here.

I'll ask Ger Teunis to build one more version, so that I could test this patch on NMT as well. "

No, you should set preallocation=2; preallocation=3 will crash Transmission.